Clean up account callback when the loopback listener fails #9
Labels
No labels
status:done
status:in-progress
status:ready
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
rexlManu/garmith-app#9
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Source review found existing behavior in openAccountCallback: a listener error rejects the outer setup promise but leaves the key promise and five-minute timeout active. The TypeScript port in
b8ed52bpreserves this behavior. Reproduce with a controlled listen failure, settle both promises, clear the timer, and close the server without changing successful login or cancellation. Do not use a real account. Deferred behind source reconstruction.Fixed in
1a4da94. Setup failure settles opening/key promises, clears the timer and closes connections/listener. Added cases for emitted and synchronous listen errors, invalid address, timeout before listening, and listener errors after setup. All 11 callback tests and desktop typecheck pass, including unchanged successful login/cancel/timeout comparisons. Only fixture keys and local loopback listeners used.